Support isodate ending with Z #357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalito
changed the title
This was referenced Jan 9, 2025
dalito
force-pushed
the
issue2096-isodate-with-Z
branch
from
c03b4a3 to
2d04371
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
==========================================
+ Coverage 63.43% 63.46% +0.02%
==========================================
Files 63 63
Lines 8982 8989 +7
Branches 2574 2578 +4
==========================================
+ Hits 5698 5705 +7
- Misses 2665 2667 +2
+ Partials 619 617 -2 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 13, 2025
isodate is already installed since it is a rdflib dependency
dalito
force-pushed
the
issue2096-isodate-with-Z
branch
from
f1a83df to
a1a6b48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR switches (for Python <3.11) to isodate package for isodate parsing. It is already installed with LinkML since it is a rdflib dependency.
Todo (maybe -> done!):
isodatepackage to Python < 3.11. Starting with Python 3.11 the standard library´sdatetime.datetime.fromisoformatis able parse isodates ending with "Z" correctly.Closes linkml/linkml#2096
Closes linkml/linkml#629